quote:

---

Originally posted by alejo46

Good morning

Please, I need your help, im a newbie in sqlserver, i coded my first sp but its not workig with the input parametres,

ths sp without pameters run OK but what i intended to do is to provide to the sp 2 input parameters: startdate and end date. i.e

exec pr_inci 20120103 20120104

the above sp yields me an error:
Server: Msg 170, Level 15, State 1, Line 1
Line 1: Incorrect syntax near '2012010

the code is this:
*
Name: pr_inci
Description: count per day the numbere of incidents in table ACA_INCIDENCIA
Author: Alejandro Vargas
Modification Log: Change

Description Date Changed By
Created procedure 2011/01/24 Alejandro Vargas
*/

CREATE PROCEDURE pr_inci
(
@START_DATE VARCHAR(8)
@END_DATE VARCHAR(8)
)
AS
SET NOCOUNT ON
SET @START_DATE = '20120103'
SET @END_DATE = '20120104'
SELECT CONVERT(VARCHAR(8),FEC_CREACION,112),COUNT(1) CANTIDAD
from ACA_INCIDENCIA
WHERE ((FEC_CREACION >= @START_DATE AND FEC_CREACION < @END_DATE)
OR (FEC_REAL >= @START_DATE AND FEC_REAL < @END_DATE)
--

1. how to get around this?
2. if i've got to modify thr code to the sp, how can i modify it ?

id appreciate your help

---

CREATE PROCEDURE pr_inci(
	@FECHA_INI DATE
	, @FECHAFIN DATE
	) 
AS BEGIN

	SET NOCOUNT ON

	SELECT
		CONVERT(VARCHAR(8),FEC_CREACION,112) AS [???]
		,COUNT(1) AS CANTIDAD
	FROM 
		ACA_INCIDENCIA
	WHERE
		(
			( FEC_CREACION >= @FECHA_INI AND FEC_CREACION < @FECHAFIN )

			OR ( FEC_REAL >= @FECHA_INI AND FEC_REAL < @FECHAFIN )

			OR ( FEC_HISTORICO >= @FECHA_INI AND FEC_HISTORICO < @FECHAFIN )
		)

		AND FUENTE=1
	GROUP BY
		CONVERT(VARCHAR(8),FEC_CREACION,112)
END