<%do while trim(objrs("min_level")) > 69 and trim(objrs("min_level")) < 76%>
<tr>
<td><%=trim(objrs("weapon"))%></td>
<td><%=trim(objrs("min_level"))%></td>
<td><%=trim(objrs("damage"))%></td>
<td><%=trim(objrs("deley"))%></td>
<td><%=trim(objrs("weapon_class"))%></td>
<td><%=trim(objrs("type"))%></td>
</tr>
<%objrs.movenext
loop%>

<%do while trim(objrs("min_level")) > 69 and trim(objrs("min_level")) < 75%>
<tr>
<td><%=trim(objrs("weapon"))%></td>
<td><%=trim(objrs("min_level"))%></td>
<td><%=trim(objrs("damage"))%></td>
<td><%=trim(objrs("deley"))%></td>
<td><%=trim(objrs("weapon_class"))%></td>
<td><%=trim(objrs("type"))%></td>
</tr>
<%objrs.movenext
loop%>

quote:

---

Originally posted by nr

oops - that will try to evaluate values on the read as well as the eof flag.
you need something like

do while not objrs.eof
if minlevel > 69 and minlevel < 80
......
endif
objrs.movenext
loop

But why not just get the rows in the resultset that you need

==========================================
Cursors are useful if you don't know sql.
DTS can be used in a similar way.
Beer is not cold and it isn't fizzy.

---

quote:

---

Originally posted by Merkin

What happens of you run the SQL statement in query analyzer ? Is there anything in the data that looks right ?

Why are you trimming a recordset value then comparing it to an integer ?


Damian
Ita erat quando hic adveni.

---

do while not objrs.eof
   if lvl > x and lvl < x
   endif
   if lvl > x and lvl < x
   endif
   if lvl > x and lvl < x
   endif
   objrs.movenext
loop

quote:

---

Originally posted by nr

The problem is with the lat one.
When it reads past the end of the file the eof flag will be set on but as fields from the resultset are accessed in the same statement as the check it will give an error.

You can replace the last loop with the code I gave above or

do while not objrs.eof
   if lvl > x and lvl < x
   endif
   if lvl > x and lvl < x
   endif
   if lvl > x and lvl < x
   endif
   objrs.movenext
loop

==========================================
Cursors are useful if you don't know sql.
DTS can be used in a similar way.
Beer is not cold and it isn't fizzy.

---

select 
  LG.LevelGroup, a.*
from
  LevelGroups LG
left outer join
  YourTable a
on
  a.Level between LG.MinLevel and LG.MaxLevel
order by
  LG.MinLevel,  ... etc ...

<%
dim LastLevelGroup
LastLevelGroup = ''

while not rs.EOF
  if LastLevelGroup <> rs!LevelGroup then
%>
    <tr>
      <td colspan="6" style="text-align: center; font-size: 18px; 
          text-decoration: underlinded">Level <%=rs!LevelGroup%></td>
    </tr>
<%
    LastLevelGroup = rs!LevelGroup
  end if
%>
  <tr>
    <td><%=trim(objrs("weapon"))%></td>
    <td><%=trim(objrs("min_level"))%></td>
    <td><%=trim(objrs("damage"))%></td>
    <td><%=trim(objrs("deley"))%></td>
    <td><%=trim(objrs("weapon_class"))%></td>
    <td><%=trim(objrs("type"))%></td>
  </tr>
<%
  rs.movenext
loop
%>

quote:

---

Originally posted by Merkin

You need some "Then" after the ifs. I think Nigel was giving you an example, for you to implement.

You've been working on this game for about 3 years now, how is it coming ?


Damian
Ita erat quando hic adveni.

---

quote:

---

Originally posted by jsmith8858

YOu are eseentially grouping by "Level" and showing a header for each new level; you shouldn't duplicate all of your code to do this, you should use a loop and write your SQL to help you out. Just add a "LevelGroup" calculation to your SELECT (something probably as convert(int, Level/10)) and keep track of when that value changes; when it does, in your loop, print your heading for that group.

If you need to be sure you get at least 1 row per group of Levels, then you can use a table of LevelGroups:

MinLevel, MaxLevel, LevelGroup
1,9,'1-9'
10,19,'10-19'
20,29,'20-29'
..etc...

then left outer join from LevelGroups to your data:

select 
  LG.LevelGroup, a.*
from
  LevelGroups LG
left outer join
  YourTable a
on
  a.Level between LG.MinLevel and LG.MaxLevel
order by
  LG.MinLevel,  ... etc ...

In your ASP code, you would then simply loop through your data like this:

<%
dim LastLevelGroup
LastLevelGroup = ''

while not rs.EOF
  if LastLevelGroup <> rs!LevelGroup then
%>
    <tr>
      <td colspan="6" style="text-align: center; font-size: 18px; 
          text-decoration: underlinded">Level <%=rs!LevelGroup%></td>
    </tr>
<%
    LastLevelGroup = rs!LevelGroup
  end if
%>
  <tr>
    <td><%=trim(objrs("weapon"))%></td>
    <td><%=trim(objrs("min_level"))%></td>
    <td><%=trim(objrs("damage"))%></td>
    <td><%=trim(objrs("deley"))%></td>
    <td><%=trim(objrs("weapon_class"))%></td>
    <td><%=trim(objrs("type"))%></td>
  </tr>
<%
  rs.movenext
loop
%>

and that's it! Much shorter, easier to maintain, more efficeint, and also more flexible. If you find yourself copying and pasting code in your programs, chances are you should either figure out a way to loop instead, or break that code out into a function.

If you have lots of pages like this to write, you might find my "ASP Report Class" code very helpful to handle things like group headers and footer very easily:

http://weblogs.sqlteam.com/jeffs/articles/526.aspx

- Jeff

---